Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Frame component #428

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

remy727
Copy link
Contributor

@remy727 remy727 commented Jul 8, 2024

WHY are these changes introduced?

Improve Frame component

WHAT is this pull request doing?

  • Support secondary menu in Frame component
  • Make detail optional
  • Support show_avatar_first boolean incase of showing avatar first

Copy link
Collaborator

@kirillplatonov kirillplatonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good overall. But adding a lookbook preview for new parameter would be great. Lookbook serves the purpose of documentation.

@remy727
Copy link
Contributor Author

remy727 commented Jul 8, 2024

Lookbook is updated.

image

@kirillplatonov kirillplatonov merged commit 549c384 into baoagency:main Jul 9, 2024
4 checks passed
@remy727 remy727 deleted the feature/improve-frame-topbar branch July 9, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants